linux-kernel - Re: [PATCH 2/2] HID: intel-ish-hid: fix endian-conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 29 May 2024 05:17:16 +0800
From: kernel test robot <lkp@...el.com>
To: Arnd Bergmann <arnd@...nel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
	Zhang Lixu <lixu.zhang@...el.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Arnd Bergmann <arnd@...db.de>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] HID: intel-ish-hid: fix endian-conversion

Hi Arnd,

kernel test robot noticed the following build errors:

[auto build test ERROR on hid/for-next]
[also build test ERROR on next-20240528]
[cannot apply to linus/master v6.10-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Arnd-Bergmann/HID-intel-ish-hid-fix-endian-conversion/20240528-200100
base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
patch link:    https://lore.kernel.org/r/20240528115802.3122955-2-arnd%40kernel.org
patch subject: [PATCH 2/2] HID: intel-ish-hid: fix endian-conversion
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240529/202405290447.n14W21hZ-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240529/202405290447.n14W21hZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405290447.n14W21hZ-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/hid/intel-ish-hid/ishtp/loader.c:178:9: error: use of undeclared identifier 'dma'
     178 |                                                  &dma, GFP_KERNEL);
         |                                                   ^
   drivers/hid/intel-ish-hid/ishtp/loader.c:186:52: error: use of undeclared identifier 'dma'
     186 |                 fragment->fragment_tbl[i].ddr_adrs = cpu_to_le64(dma);
         |                                                                  ^
   include/linux/byteorder/generic.h:86:21: note: expanded from macro 'cpu_to_le64'
      86 | #define cpu_to_le64 __cpu_to_le64
         |                     ^
   2 errors generated.


vim +/dma +178 drivers/hid/intel-ish-hid/ishtp/loader.c

   154	
   155	/**
   156	 * prepare_dma_bufs() - Prepare the DMA buffer for transferring firmware fragments
   157	 * @dev: The ISHTP device
   158	 * @ish_fw: The ISH firmware
   159	 * @fragment: The ISHTP firmware fragment descriptor
   160	 * @dma_bufs: The array of DMA fragment buffers
   161	 * @fragment_size: The size of a single DMA fragment
   162	 *
   163	 * Return: 0 on success, negative error code on failure
   164	 */
   165	static int prepare_dma_bufs(struct ishtp_device *dev,
   166				    const struct firmware *ish_fw,
   167				    struct loader_xfer_dma_fragment *fragment,
   168				    void **dma_bufs, u32 fragment_size, u32 fragment_count)
   169	{
   170		dma_addr_t dma_addr;
   171		u32 offset = 0;
   172		u32 length;
   173		int i;
   174	
   175		for (i = 0; i < fragment->fragment_cnt && offset < ish_fw->size; i++) {
   176			dma_bufs[i] = dma_alloc_coherent(dev->devc, fragment_size, &dma_addr, GFP_KERNEL);
   177			dma_bufs[i] = dma_alloc_coherent(dev->devc, fragment_size,
 > 178							 &dma, GFP_KERNEL);
   179			if (!dma_bufs[i])
   180				return -ENOMEM;
   181	
   182			fragment->fragment_tbl[i].ddr_adrs = cpu_to_le64(dma_addr);
   183	
   184			memcpy(dma_bufs[i], ish_fw->data + offset, le32_to_cpu(fragment->fragment_tbl[i].length));
   185			dma_wmb();
   186			fragment->fragment_tbl[i].ddr_adrs = cpu_to_le64(dma);
   187			length = clamp(ish_fw->size - offset, 0, fragment_size);
   188			fragment->fragment_tbl[i].length = cpu_to_le32(length);
   189			fragment->fragment_tbl[i].fw_off = cpu_to_le32(offset);
   190	
   191			offset += length;
   192		}
   193	
   194		return 0;
   195	}
   196	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki