linux-kernel - Re: [PATCH] mctp i2c: Add rx trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520cf8db945cf8dce4afdaddb59ceda65463a406.camel@codeconstruct.com.au>
Date: Wed, 29 May 2024 07:54:08 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Tal Yacobi <talycb8@...il.com>, matt@...econstruct.com.au, 
	rostedt@...dmis.org, mhiramat@...nel.org, mathieu.desnoyers@...icios.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] mctp i2c: Add rx trace

Hi Tal,

Thanks for the contribution! Some comments:

> mctp-i2c rx implementation doesn't call
> __i2c_transfer which calls the i2c reply trace function.

No, but we can trace the i2c rx path through the trace_i2c_slave
tracepoint. It is a little messier than tracing trace_i2c_write, but
has been sufficient with the debugging I've needed in the past.

> Add an mctp_reply trace function that will be used instead.

Can you elaborate a little on what you were/are looking to inspect
here? (mainly: which packet fields are you interested in?) That will
help to determine the best approach here.

Cheers,

Jeremy