linux-kernel - [PATCH v3 0/2] mm/ksm: fix some accounting problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240528-b4-ksm-counters-v3-0-34bb358fdc13@linux.dev>
Date: Tue, 28 May 2024 13:15:20 +0800
From: Chengming Zhou <chengming.zhou@...ux.dev>
To: Andrew Morton <akpm@...ux-foundation.org>, 
 David Hildenbrand <david@...hat.com>, hughd@...gle.com, aarcange@...hat.com, 
 Stefan Roesch <shr@...kernel.io>, Xiaokai Ran <ran.xiaokai@....com.cn>, 
 xu xin <xu.xin16@....com.cn>, Yang Yang <yang.yang29@....com.cn>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
 linux-fsdevel@...r.kernel.org, zhouchengming@...edance.com, 
 Chengming Zhou <chengming.zhou@...ux.dev>
Subject: [PATCH v3 0/2] mm/ksm: fix some accounting problems

Changes in v3:
- Collect Reviewed-by tag from xu xin, thanks!
- Improve the changelog of patch-2, per xu xin.
- Rebase and retest based on v6.10-rc1.
- Link to v2: https://lore.kernel.org/r/20240513-b4-ksm-counters-v2-0-f2520183a8ca@linux.dev

Changes in v2:
- Add Fixes and Acked-by tags from David Hildenbrand, thanks!
- Inline atomic_long_read(&ksm_zero_pages), per David Hildenbrand.
- Don't include the last two optimization patches to keep this fix
  simple.
- Link to v1: https://lore.kernel.org/r/20240508-b4-ksm-counters-v1-0-e2a9b13f70c5@linux.dev

We encounter some abnormal ksm_pages_scanned and ksm_zero_pages during
some random tests.

1. ksm_pages_scanned unchanged even ksmd scanning has progress.
2. ksm_zero_pages maybe -1 in some rare cases.

Thanks for review and comments!

Signed-off-by: Chengming Zhou <chengming.zhou@...ux.dev>
---
Chengming Zhou (2):
      mm/ksm: fix ksm_pages_scanned accounting
      mm/ksm: fix ksm_zero_pages accounting

 fs/proc/base.c           |  2 +-
 include/linux/ksm.h      | 17 ++++++++++++++---
 include/linux/mm_types.h |  2 +-
 mm/ksm.c                 | 17 +++++++----------
 4 files changed, 23 insertions(+), 15 deletions(-)
---
base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
change-id: 20240528-b4-ksm-counters-6a6452e23f17

Best regards,
-- 
Chengming Zhou <chengming.zhou@...ux.dev>