linux-kernel - Re: [PATCH net-next v5 1/3] net: ti: icssg-prueth: Add helper functions to configure FDB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 28 May 2024 10:57:33 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Andrew Lunn <andrew@...n.ch>
CC: Dan Carpenter <dan.carpenter@...aro.org>,
        Jan Kiszka
	<jan.kiszka@...mens.com>, Simon Horman <horms@...nel.org>,
        Vladimir Oltean
	<vladimir.oltean@....com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Niklas Schnelle <schnelle@...ux.ibm.com>,
        Arnd Bergmann <arnd@...db.de>, Diogo Ivo <diogo.ivo@...mens.com>,
        Roger Quadros <rogerq@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>, Eric Dumazet
	<edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <srk@...com>,
        Vignesh Raghavendra
	<vigneshr@...com>
Subject: Re: [PATCH net-next v5 1/3] net: ti: icssg-prueth: Add helper
 functions to configure FDB



On 28/05/24 3:34 am, Andrew Lunn wrote:
>> +struct mgmt_cmd {
>> +	u8 param;
>> +	u8 seqnum;
>> +	u8 type;
>> +	u8 header;
>> +	u32 cmd_args[3];
>> +} __packed;
> 
> There is a general dislike for __packed. Since your structures are
> naturally well aligned, it is probably not needed. You could be
> paranoid and add BUILD_BUG_ON(sizeof(struct mgmt_cmd) != 16);
> 

Sure, I will drop __packed as it's not needed and send next revision.

> 	 Andrew

-- 
Thanks and Regards,
Danish