linux-kernel - Re: [PATCH v1 1/1] PNP: Export pnp_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfqETdPQP2JBq+nWzZrsyeipV8cTspuTA7pt6b1P62wAQ@mail.gmail.com>
Date: Tue, 28 May 2024 10:10:11 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Guanbing Huang <albanhuang@...look.com>, 
	Guanbing Huang <albanhuang@...cent.com>, Woody Suwalski <terraluna977@...il.com>
Subject: Re: [PATCH v1 1/1] PNP: Export pnp_bus_type for modules

On Tue, May 28, 2024 at 7:58 AM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Mon, May 27, 2024 at 11:24:24PM +0300, Andy Shevchenko wrote:
> > Since we have dev_is_pnp() macro that utilises the address of pnp_bus_type
> > variable, the users, which can be compiled as modules, will be failed to
> > build. Export the variable to the modules to prevent build breakage.
>
> NAK.  Please move dev_is_pnp out of line and export it (as
> EXPORT_SYMBOL_GPL), please.  bus types should be private unless we have
> really good reasons for them not to be private.

Works for me, I'll redo it in the v2, thank you for the review.

-- 
With Best Regards,
Andy Shevchenko