linux-kernel - [PATCH] clk: clkdev: don't fail clkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1sBrzn-00E8GK-Ue@rmk-PC.armlinux.org.uk>
Date: Tue, 28 May 2024 09:15:47 +0100
From: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
To: linux-clk@...r.kernel.org
Cc: Stephen Boyd <sboyd@...nel.org>,
	 Ron Economos <re@...z.net>,
	 Samuel Holland <samuel.holland@...ive.com>,
	 Guenter Roeck <linux@...ck-us.net>,
	 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	 Dinh Nguyen <dinguyen@...nel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	 Michael Turquette <mturquette@...libre.com>,
	 Paul Walmsley <paul.walmsley@...ive.com>,
	 Rob Herring <robh@...nel.org>,
	 Yang Li <yang.lee@...ux.alibaba.com>,
	 linux-kernel@...r.kernel.org,
	 linux-riscv@...ts.infradead.org,
	 linux-arm-kernel@...ts.infradead.org,
	 regressions@...ts.linux.dev
Subject: [PATCH] clk: clkdev: don't fail clkdev_alloc() if over-sized

Don't fail clkdev_alloc() if the strings are over-sized. In this case,
the entry will not match during lookup, so its useless. However, since
code fails if we return NULL leading to boot failure, return a dummy
entry with the connection and device IDs set to "bad".

Leave the warning so these problems can be found, and the useless
wasteful clkdev registrations removed.

Fixes: 8d532528ff6a ("clkdev: report over-sized strings when creating clkdev entries")
Closes: https://lore.kernel.org/linux-clk/7eda7621-0dde-4153-89e4-172e4c095d01@roeck-us.net.
Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
---

Please try this patch, which should allow the platform to boot, bit will
intentionally issue lots of warnings. There is a separate patch posted
recently that removes the useless registration with clkdev.

 drivers/clk/clkdev.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index 6a77d7e201a9..2f83fb97c6fb 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -204,8 +204,15 @@ vclkdev_alloc(struct clk_hw *hw, const char *con_id, const char *dev_fmt,
 	pr_err("%pV:%s: %s ID is greater than %zu\n",
 	       &vaf, con_id, failure, max_size);
 	va_end(ap_copy);
-	kfree(cla);
-	return NULL;
+
+	/*
+	 * Don't fail in this case, but as the entry won't ever match just
+	 * fill it with something that also won't match.
+	 */
+	strscpy(cla->con_id, "bad", sizeof(cla->con_id));
+	strscpy(cla->dev_id, "bad", sizeof(cla->dev_id));
+
+	return &cla->cl;
 }
 
 static struct clk_lookup *
-- 
2.30.2