linux-kernel - [PATCH] ovl: change error message to info for empty lowerdir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240528090244.6746-1-ecurtin@redhat.com>
Date: Tue, 28 May 2024 10:02:40 +0100
From: Eric Curtin <ecurtin@...hat.com>
To: linux-unionfs@...r.kernel.org (open list:OVERLAY FILESYSTEM)
Cc: Alexander Larsson <alexl@...hat.com>,
	Eric Curtin <ecurtin@...hat.com>,
	Wei Wang <weiwang@...hat.com>,
	Miklos Szeredi <miklos@...redi.hu>,
	Amir Goldstein <amir73il@...il.com>,
	linux-unionfs@...r.kernel.org (open list:OVERLAY FILESYSTEM),
	linux-kernel@...r.kernel.org (open list)
Subject: [PATCH] ovl: change error message to info for empty lowerdir

In some deployments, an empty lowerdir is not considered an error.
The current implementation logs this scenario as an error during boot,
which can be misleading and cause unnecessary concern for users. This
commit changes the log level from pr_err to pr_info to reflect the
non-error nature of an empty lowerdir in these cases.

Reported-by: Wei Wang <weiwang@...hat.com>
Signed-off-by: Eric Curtin <ecurtin@...hat.com>
---
 fs/overlayfs/params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c
index 4860fcc4611bb..53170d73bb79c 100644
--- a/fs/overlayfs/params.c
+++ b/fs/overlayfs/params.c
@@ -231,7 +231,7 @@ static int ovl_mount_dir_noesc(const char *name, struct path *path)
 	int err = -EINVAL;
 
 	if (!*name) {
-		pr_err("empty lowerdir\n");
+		pr_info("empty lowerdir\n");
 		goto out;
 	}
 	err = kern_path(name, LOOKUP_FOLLOW, path);
-- 
2.45.0