linux-kernel - Re: [PATCH net-next v3 2/2] net: phy: xilinx-gmii2rgmii: Adopt clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d104a345-7df1-4fce-a9d4-05f539fc9160@intel.com>
Date: Tue, 28 May 2024 11:33:12 +0200
From: Wojciech Drewek <wojciech.drewek@...el.com>
To: Vineeth Karumanchi <vineeth.karumanchi@....com>, <git@....com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<conor+dt@...nel.org>, <harini.katakam@....com>, <andrew@...n.ch>,
	<hkallweit1@...il.com>, <linux@...linux.org.uk>, <michal.simek@....com>
CC: <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next v3 2/2] net: phy: xilinx-gmii2rgmii: Adopt clock
 support



On 28.05.2024 08:20, Vineeth Karumanchi wrote:
> Add clock support to the gmii_to_rgmii IP.
> Make clk optional to keep DTB backward compatibility.
> 
> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@....com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>

>  drivers/net/phy/xilinx_gmii2rgmii.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
> index 7b1bc5fcef9b..7c51daecf18e 100644
> --- a/drivers/net/phy/xilinx_gmii2rgmii.c
> +++ b/drivers/net/phy/xilinx_gmii2rgmii.c
> @@ -15,6 +15,7 @@
>  #include <linux/mii.h>
>  #include <linux/mdio.h>
>  #include <linux/phy.h>
> +#include <linux/clk.h>
>  #include <linux/of_mdio.h>
>  
>  #define XILINX_GMII2RGMII_REG		0x10
> @@ -85,11 +86,17 @@ static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
>  	struct device *dev = &mdiodev->dev;
>  	struct device_node *np = dev->of_node, *phy_node;
>  	struct gmii2rgmii *priv;
> +	struct clk *clkin;
>  
>  	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
>  	if (!priv)
>  		return -ENOMEM;
>  
> +	clkin = devm_clk_get_optional_enabled(dev, NULL);
> +	if (IS_ERR(clkin))
> +		return dev_err_probe(dev, PTR_ERR(clkin),
> +					"Failed to get and enable clock from Device Tree\n");
> +
>  	phy_node = of_parse_phandle(np, "phy-handle", 0);
>  	if (!phy_node) {
>  		dev_err(dev, "Couldn't parse phy-handle\n");