linux-kernel - Re: [PATCH RFC v2] fhandle: expose u64 mount id to name_to_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZlW4a6Zdt9SPTt80@infradead.org>
Date: Tue, 28 May 2024 03:56:43 -0700
From: "hch@...radead.org" <hch@...radead.org>
To: Jan Kara <jack@...e.cz>
Cc: "hch@...radead.org" <hch@...radead.org>,
	Trond Myklebust <trondmy@...merspace.com>,
	"chuck.lever@...cle.com" <chuck.lever@...cle.com>,
	"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"brauner@...nel.org" <brauner@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alex.aring@...il.com" <alex.aring@...il.com>,
	"cyphar@...har.com" <cyphar@...har.com>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"jlayton@...nel.org" <jlayton@...nel.org>,
	"amir73il@...il.com" <amir73il@...il.com>,
	"linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>
Subject: Re: [PATCH RFC v2] fhandle: expose u64 mount id to
 name_to_handle_at(2)

On Tue, May 28, 2024 at 12:11:52PM +0200, Jan Kara wrote:
> So some fanotify users may use open_by_handle_at() and name_to_handle_at()
> but we specifically designed fanotify to not depend on this mount id
> feature of the API (because it wasn't really usable couple of years ago
> when we were designing this with Amir). fanotify returns fsid + fhandle in
> its events and userspace is expected to build a mapping of fsid ->
> "whatever it needs to identify a filesystem" when placing fanotify marks.
> If it wants to open file / directory where events happened, then this
> usually means keeping fsid -> "some open fd on fs" mapping so that it can
> then use open_by_handle_at() for opening.

Which seems like another argument for my version of the handles to
include the fsid.  Although IIRC the fanotify fsid is only 64 bits which
isn't really good entropy, so we might have to rev that as well.