linux-kernel - Re: [PATCH] ovl: change error message to info for empty lowerdir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegu+z2Nxvk2H9vfZ3nfzEEixUG4kEthVGHWUYw0wX5bgMg@mail.gmail.com>
Date: Tue, 28 May 2024 13:34:39 +0200
From: Miklos Szeredi <miklos@...redi.hu>
To: Eric Curtin <ecurtin@...hat.com>
Cc: "open list:OVERLAY FILESYSTEM" <linux-unionfs@...r.kernel.org>, Alexander Larsson <alexl@...hat.com>, 
	Wei Wang <weiwang@...hat.com>, Amir Goldstein <amir73il@...il.com>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ovl: change error message to info for empty lowerdir

On Tue, 28 May 2024 at 12:55, Eric Curtin <ecurtin@...hat.com> wrote:
>
> On Tue, 28 May 2024 at 11:34, Miklos Szeredi <miklos@...redi.hu> wrote:
> >
> > On Tue, 28 May 2024 at 11:03, Eric Curtin <ecurtin@...hat.com> wrote:
> > >
> > > In some deployments, an empty lowerdir is not considered an error.
> >
> > I don't think this can be triggered in upstream kernel and can be
> > removed completely.
>
> True... Just switched to Fedora Rawhide and instead we just see this one:
>
> pr_err("cannot append lower layer");
>
> >
> > Or do you have a reproducer?
>
> Run one of these vms:
>
> https://github.com/osbuild/bootc-image-builder

Apparently it is using the legacy lowerdir append mode
"lowerdir=:foo".  This works only on 6.5.

In 6.6 and later the same can be achieved with "lowerdir+=foo".

It's strange that there are not side effects other then the error message.

Thanks,
Miklos