linux-kernel - Re: [PATCH v3 5/7] arm64: dts: ti: k3-j722s: Add lane mux for Serdes1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 28 May 2024 18:12:35 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Roger Quadros <rogerq@...nel.org>
CC: Siddharth Vadapalli <s-vadapalli@...com>, <nm@...com>, <vigneshr@...com>,
        <afd@...com>, <kristo@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <u-kumar1@...com>,
        <danishanwar@...com>, <srk@...com>
Subject: Re: [PATCH v3 5/7] arm64: dts: ti: k3-j722s: Add lane mux for Serdes1

On Tue, May 28, 2024 at 03:23:32PM +0300, Roger Quadros wrote:
> 
> 
> On 24/05/2024 12:05, Siddharth Vadapalli wrote:
> > The Serdes1 instance of Serdes on J722S SoC can be muxed between PCIe0
> 
> Please use SERDES insted of Serdes or serdes as it is an abbreviation.

Ok.

> 
> > and SGMII1. Update the "serdes_ln_ctrl" node adding support for the lane
> > mux of Serdes1. Additionally, set the default muxing for Serdes1 Lane0 to
> > PCIe0.
> > 
> > Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>
> > ---
> > Current patch is v1. No changelog.
> > 

[...]

> > @@ -96,8 +96,9 @@ usb1: usb@...00000{
> >  &main_conf {
> >  	serdes_ln_ctrl: mux-controller@...0 {
> >  		compatible = "reg-mux";
> > -		reg = <0x4080 0x4>;
> > +		reg = <0x4080 0x14>;
> >  		#mux-control-cells = <1>;
> > -		mux-reg-masks = <0x0 0x3>; /* SERDES0 lane0 select */
> > +		mux-reg-masks = <0x0 0x3>, /* SERDES0 lane0 select */
> > +				<0x10 0x3>; /* SERDES1 lane0 select */
> 
> Why not introduce this right in the patch where you add serdes_ln_ctrl mux node?

I was preserving patch authorship from the v2 series. I will combine
this in the v4 with a Co-developed-by tag.

Regards,
Siddharth.