linux-kernel - Re: [PATCH net] net: smc91x: Remove commented out code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f596a8bf3f0ff2c498e7b6cf922fa28bd0dbef4.camel@redhat.com>
Date: Tue, 28 May 2024 15:36:28 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Thorsten Blum <thorsten.blum@...lux.com>, Nicolas Pitre
 <nico@...xnic.net>,  "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
 Breno Leitao <leitao@...ian.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: smc91x: Remove commented out code

Hi,

On Mon, 2024-05-27 at 12:55 +0200, Thorsten Blum wrote:
> Remove commented out code
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  drivers/net/ethernet/smsc/smc91x.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
> index 78ff3af7911a..907498848028 100644
> --- a/drivers/net/ethernet/smsc/smc91x.c
> +++ b/drivers/net/ethernet/smsc/smc91x.c
> @@ -1574,12 +1574,8 @@ smc_ethtool_set_link_ksettings(struct net_device *dev,
>  		    (cmd->base.port != PORT_TP && cmd->base.port != PORT_AUI))
>  			return -EINVAL;
>  
> -//		lp->port = cmd->base.port;
>  		lp->ctl_rfduplx = cmd->base.duplex == DUPLEX_FULL;
>  
> -//		if (netif_running(dev))
> -//			smc_set_port(dev);
> -
>  		ret = 0;
>  	}
>  
This is net-next material, please re-submit targeting the correct tree
in the subj prefix.

Thanks

Paolo