linux-kernel - Re: [PATCH] watchdog: lenovo_se10_wdt: add HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fed00be4-2974-40cb-9d87-6c7c69cc1b98@roeck-us.net>
Date: Tue, 28 May 2024 06:37:58 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Arnd Bergmann <arnd@...nel.org>, Wim Van Sebroeck
 <wim@...ux-watchdog.org>, Mark Pearson <mpearson-lenovo@...ebb.ca>,
 David Ober <dober@...ovo.com>
Cc: Arnd Bergmann <arnd@...db.de>, Hans de Goede <hdegoede@...hat.com>,
 linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: lenovo_se10_wdt: add HAS_IOPORT dependency

On 5/28/24 05:07, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Once the inb()/outb() helpers become conditional, the newly added driver
> fails to link on targets without CONFIG_HAS_IOPORT:
> 
> In file included from arch/arm64/include/asm/io.h:299,
>                   from include/linux/io.h:14,
>                   from drivers/watchdog/lenovo_se10_wdt.c:8:
> drivers/watchdog/lenovo_se10_wdt.c: In function 'set_bram':
> include/asm-generic/io.h:596:15: error: call to '_outb' declared with attribute error: outb() requires CONFIG_HAS_IOPORT
>    596 | #define _outb _outb
> include/asm-generic/io.h:655:14: note: in expansion of macro '_outb'
>    655 | #define outb _outb
>        |              ^~~~~
> drivers/watchdog/lenovo_se10_wdt.c:67:9: note: in expansion of macro 'outb'
>     67 |         outb(offset, bram_base);
>        |         ^~~~
> 
> Add the same dependency we added to the other such drivers.
> 
> Fixes: 1f6602c8ed1e ("watchdog: lenovo_se10_wdt: Watchdog driver for Lenovo SE10 platform")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 5f91921afc79..24ea3b6f95fe 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -257,6 +257,7 @@ config GPIO_WATCHDOG_ARCH_INITCALL
>   config LENOVO_SE10_WDT
>   	tristate "Lenovo SE10 Watchdog"
>   	depends on (X86 && DMI) || COMPILE_TEST
> +	depends on HAS_IOPORT
>   	select WATCHDOG_CORE
>   	help
>   	  If you say yes here you get support for the watchdog