[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7f9db4de-635f-6204-d261-3bcd0aac1c25@amd.com>
Date: Wed, 29 May 2024 10:20:28 -0500
From: Tom Lendacky <thomas.lendacky@....com>
To: Mario Limonciello <mario.limonciello@....com>,
Herbert Xu <herbert@...dor.apana.org.au>
Cc: "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..."
<linux-crypto@...r.kernel.org>, Richard Hughes <hughsient@...il.com>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/5] crypto: ccp: Move security attributes to their own
file
On 5/28/24 16:07, Mario Limonciello wrote:
> To prepare for other code that will manipulate security attributes
> move the handling code out of sp-pci.c. No intended functional changes.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
> v1->v2:
> * Only add psp_security_attr_group when PSP support enabled
> (Fixes lkp robot reported Kconfig issue)
Just verifying that there's no change in behavior in regards to whether
the attributes are shown. Previously the attributes were not shown if
CONFIG_CRYPTO_DEV_SP_PSP was "n" because the psp value would be NULL in
psp_security_is_visible(), right?
Thanks,
Tom
> ---
> MAINTAINERS | 6 ++++
> drivers/crypto/ccp/Makefile | 3 +-
> drivers/crypto/ccp/hsti.c | 68 ++++++++++++++++++++++++++++++++++++
> drivers/crypto/ccp/hsti.h | 15 ++++++++
> drivers/crypto/ccp/psp-dev.c | 1 +
> drivers/crypto/ccp/sp-pci.c | 58 ++----------------------------
> 6 files changed, 95 insertions(+), 56 deletions(-)
> create mode 100644 drivers/crypto/ccp/hsti.c
> create mode 100644 drivers/crypto/ccp/hsti.h
>
Powered by blists - more mailing lists