linux-kernel - RE: [PATCH] EDAC, i10nm: make skx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB60838B76940188104D57E53FFCF22@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Wed, 29 May 2024 16:14:47 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: Arnd Bergmann <arnd@...nel.org>, Borislav Petkov <bp@...en8.de>, "Zhuo,
 Qiuxu" <qiuxu.zhuo@...el.com>
CC: Arnd Bergmann <arnd@...db.de>, James Morse <james.morse@....com>, "Mauro
 Carvalho Chehab" <mchehab@...nel.org>, Robert Richter <rric@...nel.org>,
	Marvin Lin <milkfafa@...il.com>, Shubhrajyoti Datta
	<shubhrajyoti.datta@....com>, Sai Krishna Potthuri
	<sai.krishna.potthuri@....com>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] EDAC, i10nm: make skx_common.o a separate module

> Linking an object file into multiple modules causes a warning:
>
> scripts/Makefile.build:236: drivers/edac/Makefile: skx_common.o is added to multiple modules: i10nm_edac skx_edac

In this case there is no practical problem from this double link. The two modules created: skx_edac.ko and i10nm_edac.ko
are mutually exclusive. A system may load neither, either, but not both (enforced by the x86_match_cpu() check in each
modules init function).

> Make this a separate module instead.

> +EXPORT_SYMBOL_GPL(skx_adxl_get);
> +EXPORT_SYMBOL_GPL(skx_adxl_put);
> +EXPORT_SYMBOL_GPL(skx_set_mem_cfg);
> +EXPORT_SYMBOL_GPL(skx_set_decode);
> +EXPORT_SYMBOL_GPL(skx_get_src_id);
> +EXPORT_SYMBOL_GPL(skx_get_node_id);
> +EXPORT_SYMBOL_GPL(skx_get_all_bus_mappings);
> +EXPORT_SYMBOL_GPL(skx_get_hi_lo);
> +EXPORT_SYMBOL_GPL(skx_get_dimm_info);
> +EXPORT_SYMBOL_GPL(skx_get_nvdimm_info);
> +EXPORT_SYMBOL_GPL(skx_register_mci);
> +EXPORT_SYMBOL_GPL(skx_mce_check_error);
> +EXPORT_SYMBOL_GPL(skx_remove);

With all these new EXPORTs ... perhaps drivers/edac should start
using a local export name space?

    -DDEFAULT_SYMBOL_NAMESPACE=EDAC ?


But maybe a better fix might be to somehow tag skx_common.o to tell the
checker script "It's OK. I meant to do that."

-Tony