linux-kernel - Re: [PATCH v2 2/5] crypto: ccp: Move security attributes to their own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0293a49-3609-a83a-f129-97ead8467057@amd.com>
Date: Wed, 29 May 2024 11:50:24 -0500
From: Tom Lendacky <thomas.lendacky@....com>
To: Mario Limonciello <mario.limonciello@....com>,
 Herbert Xu <herbert@...dor.apana.org.au>
Cc: "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..."
 <linux-crypto@...r.kernel.org>, Richard Hughes <hughsient@...il.com>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/5] crypto: ccp: Move security attributes to their own
 file

On 5/29/24 11:22, Mario Limonciello wrote:
> On 5/29/2024 10:20, Tom Lendacky wrote:
>> On 5/28/24 16:07, Mario Limonciello wrote:
>>> To prepare for other code that will manipulate security attributes
>>> move the handling code out of sp-pci.c. No intended functional changes.
>>>
>>> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
>>> ---
>>> v1->v2:
>>>   * Only add psp_security_attr_group when PSP support enabled
>>>     (Fixes lkp robot reported Kconfig issue)
>>
>> Just verifying that there's no change in behavior in regards to 
>> whether the attributes are shown. Previously the attributes were not 
>> shown if CONFIG_CRYPTO_DEV_SP_PSP was "n" because the psp value would 
>> be NULL in psp_security_is_visible(), right?
> 
> Yes; that's right.

Acked-by: Tom Lendacky <thomas.lendacky@....com>

>