lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c17774d8-11b3-4f59-a995-329bf2300fce@intel.com>
Date: Wed, 29 May 2024 10:42:47 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	<linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>, Babu Moger
	<babu.moger@....com>, Maciej Wieczór-Retman
	<maciej.wieczor-retman@...el.com>
CC: <linux-kernel@...r.kernel.org>, Fenghua Yu <fenghua.yu@...el.com>, "Shuah
 Khan" <skhan@...uxfoundation.org>
Subject: Re: [PATCH v4 01/16] selftests/resctrl: Fix closing IMC fds on error
 and open-code R+W instead of loops

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> The imc perf fd close() calls are missing from all error paths. In
> addition, get_mem_bw_imc() handles fds in a for loop but close() is
> based on two fixed indexes READ and WRITE.
> 
> Open code inner for loops to READ+WRITE entries for clarity and add a
> function to close() IMC fds properly in all cases.
> 
> Fixes: 7f4d257e3a2a ("selftests/resctrl: Add callback to start a benchmark")
> Suggested-by: Reinette Chatre <reinette.chatre@...el.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ