linux-kernel - Re: [PATCH v4 05/16] selftests/resctrl: Use correct type for pids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 29 May 2024 10:44:01 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	<linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>, Babu Moger
	<babu.moger@....com>, Maciej Wieczór-Retman
	<maciej.wieczor-retman@...el.com>
CC: <linux-kernel@...r.kernel.org>, Fenghua Yu <fenghua.yu@...el.com>, "Shuah
 Khan" <skhan@...uxfoundation.org>
Subject: Re: [PATCH v4 05/16] selftests/resctrl: Use correct type for pids

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> A few functions receive PIDs through int arguments. PIDs variables
> should be of type pid_t, not int.
> 
> Convert pid arguments from int to pid_t.
> 

This looks good to me. A couple of places remain that treat
pid_t as int ... that is via the %d format specifier
used to do the printing in print_results_cache() as well as
print_results_bw(). I understand we do not see any warnings
since these are indeed int. So, I wonder if an explicit (int) cast
would not make things obvious and match the stated goal of
not treating pid_t as int?

Reinette