linux-kernel - Re: [PATCH v4 11/16] selftests/resctrl: Simplify bandwidth report type handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <446beadc-d334-4f80-b8d7-53b51b85816b@intel.com>
Date: Wed, 29 May 2024 10:46:56 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	<linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>, Babu Moger
	<babu.moger@....com>, Maciej Wieczór-Retman
	<maciej.wieczor-retman@...el.com>
CC: <linux-kernel@...r.kernel.org>, Fenghua Yu <fenghua.yu@...el.com>, "Shuah
 Khan" <skhan@...uxfoundation.org>
Subject: Re: [PATCH v4 11/16] selftests/resctrl: Simplify bandwidth report
 type handling

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> bw_report is only needed for selecting the correct value from the
> values IMC measured. It is a member in the resctrl_val_param struct and
> is always set to "reads". The value is then checked in resctrl_val()
> using validate_bw_report_request() that besides validating the input,
> assumes it can mutate the string which is questionable programming
> practice.
> 
> Simplify handling bw_report:
> 
> - Convert validate_bw_report_request() into get_bw_report_type() that
>    inputs and returns const char *. Use NULL to indicate error.
> 
> - Validate the report types inside measure_mem_bw(), not in
>    resctrl_val().
> 
> - As resctrl_val() no longer needs bw_report for anything, it can just
>    be passed to measure_mem_bw() by the ->measure() hooks.

Needs imperative tone

> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette