linux-kernel - Re: [PATCH v4 14/16] selftests/resctrl: Remove mongrp from MBA test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2a8e8ad-311c-4302-a200-03fc9f02b20b@intel.com>
Date: Wed, 29 May 2024 10:49:07 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	<linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>, Babu Moger
	<babu.moger@....com>, Maciej Wieczór-Retman
	<maciej.wieczor-retman@...el.com>
CC: <linux-kernel@...r.kernel.org>, Fenghua Yu <fenghua.yu@...el.com>, "Shuah
 Khan" <skhan@...uxfoundation.org>
Subject: Re: [PATCH v4 14/16] selftests/resctrl: Remove mongrp from MBA test

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> Nothing during MBA test uses mongrp even if it has been defined ever
> since the introduction of the MBA test in the commit 01fee6b4d1f9
> ("selftests/resctrl: Add MBA test").
> 
> Remove the mongrp from MBA test.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>   tools/testing/selftests/resctrl/mba_test.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c
> index 9c9a4f22e529..5e0b1e794295 100644
> --- a/tools/testing/selftests/resctrl/mba_test.c
> +++ b/tools/testing/selftests/resctrl/mba_test.c
> @@ -166,7 +166,6 @@ static int mba_run_test(const struct resctrl_test *test, const struct user_param
>   	struct resctrl_val_param param = {
>   		.resctrl_val	= MBA_STR,
>   		.ctrlgrp	= "c1",
> -		.mongrp		= "m1",
>   		.filename	= RESULT_FILE_NAME,
>   		.init		= mba_init,
>   		.setup		= mba_setup,

This may explain the unexpected checks that are removed in final patch?

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette