linux-kernel - Re: [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06380175-c258-4112-8cc4-4420b2860e7f@oracle.com>
Date: Wed, 29 May 2024 11:58:12 -0700
From: Himanshu Madhani <himanshu.madhani@...cle.com>
To: linux@...blig.org, njavali@...vell.com,
        GR-QLogic-Storage-Upstream@...vell.com,
        James.Bottomley@...senPartnership.com, martin.petersen@...cle.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'



On 5/28/24 14:56, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> 'scsi_dif_tuple' is unused since
> commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized
> sectors.").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>   drivers/scsi/qla2xxx/qla_isr.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index d48007e18288..fe98c76e9be3 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -3014,12 +3014,6 @@ qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len,
>   	}
>   }
>   
> -struct scsi_dif_tuple {
> -	__be16 guard;       /* Checksum */
> -	__be16 app_tag;         /* APPL identifier */
> -	__be32 ref_tag;         /* Target LBA or indirect LBA */
> -};
> -
>   /*
>    * Checks the guard or meta-data for the type of error
>    * detected by the HBA. In case of errors, we set the

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@...cle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering