linux-kernel - Re: [PATCH] EDAC, i10nm: make skx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <fc7f2a95-2a61-4eea-a1b8-b764893eabe3@app.fastmail.com>
Date: Wed, 29 May 2024 21:55:04 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Borislav Petkov" <bp@...en8.de>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Tony Luck" <tony.luck@...el.com>, "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>,
 "James Morse" <james.morse@....com>,
 "Mauro Carvalho Chehab" <mchehab@...nel.org>,
 "Robert Richter" <rric@...nel.org>, "Marvin Lin" <milkfafa@...il.com>,
 "Shubhrajyoti Datta" <shubhrajyoti.datta@....com>,
 "Sai Krishna Potthuri" <sai.krishna.potthuri@....com>,
 "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC, i10nm: make skx_common.o a separate module

On Wed, May 29, 2024, at 21:31, Borislav Petkov wrote:
> On Wed, May 29, 2024 at 11:51:11AM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> Linking an object file into multiple modules causes a warning:
>> 
>> scripts/Makefile.build:236: drivers/edac/Makefile: skx_common.o is added to multiple modules: i10nm_edac skx_edac
>
> What changed?
>
> This wasn't an issue until now-ish...

It has caused problems in enough other drivers that we now
have a warning for it, it was added in commit 598afa050403
("kbuild: warn objects shared among multiple modules").

Most modules are modified already, and we are now down to
the last handful. Since the bugs are fairly hard to understand
when they happen, it would be nice to enable the warning
by default.

     Arnd