linux-kernel - Re: [PATCH] mm/hugetlb: Do not call vma_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 29 May 2024 22:35:48 +0200
From: Oscar Salvador <osalvador@...e.com>
To: Breno Leitao <leitao@...ian.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Muchun Song <muchun.song@...ux.dev>,
	syzbot+d3fe2dc5ffe9380b714b@...kaller.appspotmail.com
Subject: Re: [PATCH] mm/hugetlb: Do not call vma_add_reservation upon ENOMEM

On Wed, May 29, 2024 at 08:43:06AM -0700, Breno Leitao wrote:
> vma_needs_reservation returns a long.
> 
> 	static long vma_needs_reservation(struct hstate *h,
> 				struct vm_area_struct *vma, unsigned long addr)

Yeah, I missed that, thanks.

@Andrew: Can you fold the following in? Thanks


diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index f35abff8be60..0b9e64aa279b 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -5769,7 +5769,7 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
 		 * forever.
 		 */
 		if (adjust_reservation) {
-			int rc = vma_needs_reservation(h, vma, address);
+			long rc = vma_needs_reservation(h, vma, address);
 
 			if (rc < 0)
 				/* Pressumably allocate_file_region_entries failed

> Reviewed-by: Breno Leitao <leitao@...ian.org>

Thanks


-- 
Oscar Salvador
SUSE Labs