linux-kernel - RE: [PATCH v6 3/3] scsi: ufs: sysfs: Make max_number_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 29 May 2024 21:12:54 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: Bean Huo <beanhuo@...ron.com>, Peter Wang <peter.wang@...iatek.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 3/3] scsi: ufs: sysfs: Make max_number_of_rtt
 read-write

> On 5/26/24 01:16, Avri Altman wrote:
> > +static inline void ufshcd_freez_hw_queues(struct ufs_hba *hba) {
> > +     struct scsi_device *sdev;
> > +
> > +     shost_for_each_device(sdev, hba->host) {
> > +             if (sdev == hba->ufs_device_wlun)
> > +                     continue;
> > +             blk_mq_freeze_queue(sdev->request_queue);
> > +             blk_mq_quiesce_queue(sdev->request_queue);
> > +     }
> > +}
> > +
> > +static inline void ufshcd_unfreez_hw_queues(struct ufs_hba *hba) {
> > +     struct scsi_device *sdev;
> > +
> > +     shost_for_each_device(sdev, hba->host) {
> > +             if (sdev == hba->ufs_device_wlun)
> > +                     continue;
> > +             blk_mq_unquiesce_queue(sdev->request_queue);
> > +             blk_mq_unfreeze_queue(sdev->request_queue);
> > +     }
> > +}
> 
> Why have these functions been declared inline? blk_mq_freeze_queue() may
> sleep and hence performance is not an argument to inline these functions.
> Additionally, the WLUN should not be skipped when freezing or unfreezing
> request queues. The blk_mq_quiesce_queue() and
> blk_mq_unquiesce_queue() calls are not necessary in the above code.
> Please remove these.
OK.

Thanks,
Avri

> 
> Thanks,
> 
> Bart.