[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <171701799909.3874213.18222110572993533642.robh@kernel.org>
Date: Wed, 29 May 2024 16:26:39 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
Krzysztof Kozlowski <krzk+dt@...nel.org>, imx@...ts.linux.dev,
Vladimir Oltean <olteanv@...il.com>, linux-kernel@...r.kernel.org,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/1] spi: dt-bindings: fsl-dspi: Convert to yaml format
On Wed, 29 May 2024 15:36:50 -0400, Frank Li wrote:
> Convert dt-binding spi-fsl-dspi.txt to yaml format.
>
> Addtional changes during convert:
> - compatible string "fsl,ls1028a-dspi" can be followed by
> fsl,ls1021a-v1.0-dspi
> - Change "dspi0@...2c000" to "spi@...2c000" in example
> - Reorder properties in example
> - Use GIC include in example
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>
> Notes:
> pass dt_binding_check
>
> make dt_binding_check DT_SCHEMA_FILES=fsl,dspi.yaml
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> CHKDT Documentation/devicetree/bindings
> LINT Documentation/devicetree/bindings
> DTEX Documentation/devicetree/bindings/spi/fsl,dspi.example.dts
> DTC_CHK Documentation/devicetree/bindings/spi/fsl,dspi.example.dtb
>
> .../devicetree/bindings/spi/fsl,dspi.yaml | 126 ++++++++++++++++++
> .../devicetree/bindings/spi/spi-fsl-dspi.txt | 65 ---------
> 2 files changed, 126 insertions(+), 65 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/spi/fsl,dspi.yaml
> delete mode 100644 Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/spi/fsl,dspi.example.dtb: /example-0/spi@...2c000/flash@0: failed to match any schema with compatible: ['atmel,at26df081a']
doc reference errors (make refcheckdocs):
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
MAINTAINERS: Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240529193651.1029840-1-Frank.Li@nxp.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists