linux-kernel - Re: [PATCH] selftests/overlayfs: Fix build error on ppc64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f3a70ba-40d2-4624-b8c5-7c3ae2a025fb@linuxfoundation.org>
Date: Wed, 29 May 2024 16:19:11 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Michael Ellerman <mpe@...erman.id.au>, linux-kselftest@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 Shuah Khan <skhan@...uxfoundation.org>, shuah <shuah@...nel.org>
Subject: Re: [PATCH] selftests/overlayfs: Fix build error on ppc64

On 5/20/24 20:26, Michael Ellerman wrote:
> Fix build error on ppc64:
>    dev_in_maps.c: In function ‘get_file_dev_and_inode’:
>    dev_in_maps.c:60:59: error: format ‘%llu’ expects argument of type
>    ‘long long unsigned int *’, but argument 7 has type ‘__u64 *’ {aka ‘long
>    unsigned int *’} [-Werror=format=]
> 
> By switching to unsigned long long for u64 for ppc64 builds.
> 
> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
> ---
>   tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c b/tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c
> index 759f86e7d263..2862aae58b79 100644
> --- a/tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c
> +++ b/tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c
> @@ -1,5 +1,6 @@
>   // SPDX-License-Identifier: GPL-2.0
>   #define _GNU_SOURCE
> +#define __SANE_USERSPACE_TYPES__ // Use ll64
>   
>   #include <inttypes.h>
>   #include <unistd.h>

Applied to linux-kselftest fixes for the next rc.

Michael, If you want to take this through, let me know, I can drop this.

thanks,
-- Shuah