linux-kernel - Re: [PATCH v2 1/3] hwmon: (ltc2992) Fix memory leak in ltc2992_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a44d1612-0731-4f9f-aa93-04864599251c@roeck-us.net>
Date: Wed, 29 May 2024 15:35:09 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Daniel Scally <djrscally@...il.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Jean Delvare <jdelvare@...e.com>,
	Antoniu Miclaus <antoniu.miclaus@...log.com>,
	Jonathan Cameron <jic23@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2 1/3] hwmon: (ltc2992) Fix memory leak in
 ltc2992_parse_dt()

On Thu, May 23, 2024 at 05:47:14PM +0200, Javier Carrasco wrote:
> A new error path was added to the fwnode_for_each_available_node() loop
> in ltc2992_parse_dt(), which leads to an early return that requires a
> call to fwnode_handle_put() to avoid a memory leak in that case.
> 
> Add the missing fwnode_handle_put() in the error path from a zero value
> shunt resistor.
> 
> Cc: stable@...r.kernel.org
> Fixes: 10b029020487 ("hwmon: (ltc2992) Avoid division by zero")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/ltc2992.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/ltc2992.c b/drivers/hwmon/ltc2992.c
> index 229aed15d5ca..d4a93223cd3b 100644
> --- a/drivers/hwmon/ltc2992.c
> +++ b/drivers/hwmon/ltc2992.c
> @@ -876,9 +876,11 @@ static int ltc2992_parse_dt(struct ltc2992_state *st)
>  
>  		ret = fwnode_property_read_u32(child, "shunt-resistor-micro-ohms", &val);
>  		if (!ret) {
> -			if (!val)
> +			if (!val) {
> +				fwnode_handle_put(child);
>  				return dev_err_probe(&st->client->dev, -EINVAL,
>  						     "shunt resistor value cannot be zero\n");
> +			}
>  			st->r_sense_uohm[addr] = val;
>  		}
>  	}