linux-kernel - RE: [EXTERNAL] Re: [PATCH v2] ASoc: tas2781: Playback can work when only RCA binary loading without dsp firmware loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 29 May 2024 07:12:29 +0000
From: "Ding, Shenghao" <shenghao-ding@...com>
To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        "broonie@...nel.org" <broonie@...nel.org>
CC: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz"
	<perex@...ex.cz>,
        "13916275206@....com" <13916275206@....com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "Salazar, Ivan"
	<i-salazar@...com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "Chadha, Jasjot Singh" <j-chadha@...com>,
        "liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
        "Yue, Jaden"
	<jaden-yue@...com>,
        "yung-chuan.liao@...ux.intel.com"
	<yung-chuan.liao@...ux.intel.com>,
        "Rao, Dipa" <dipa@...com>, "Lu, Kevin"
	<kevin-lu@...com>,
        "yuhsuan@...gle.com" <yuhsuan@...gle.com>,
        "tiwai@...e.de"
	<tiwai@...e.de>, "Xu, Baojun" <baojun.xu@...com>,
        "soyer@....hu"
	<soyer@....hu>,
        "Baojun.Xu@....com" <Baojun.Xu@....com>,
        "judyhsiao@...gle.com" <judyhsiao@...gle.com>,
        "Navada Kanyana, Mukund"
	<navada@...com>,
        "cujomalainey@...gle.com" <cujomalainey@...gle.com>,
        "Kutty,
 Aanya" <aanya@...com>,
        "Mahmud, Nayeem" <nayeem.mahmud@...com>
Subject: RE: [EXTERNAL] Re: [PATCH v2] ASoc: tas2781: Playback can work when
 only RCA binary loading without dsp firmware loading



> -----Original Message-----
> From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> Sent: Monday, May 27, 2024 9:44 PM
> To: Ding, Shenghao <shenghao-ding@...com>; broonie@...nel.org
> Cc: andriy.shevchenko@...ux.intel.com; lgirdwood@...il.com;
> perex@...ex.cz; 13916275206@....com; alsa-devel@...a-project.org;
> Salazar, Ivan <i-salazar@...com>; linux-kernel@...r.kernel.org; Chadha,
> Jasjot Singh <j-chadha@...com>; liam.r.girdwood@...el.com; Yue, Jaden
> <jaden-yue@...com>; yung-chuan.liao@...ux.intel.com; Rao, Dipa
> <dipa@...com>; Lu, Kevin <kevin-lu@...com>; yuhsuan@...gle.com;
> tiwai@...e.de; Xu, Baojun <baojun.xu@...com>; soyer@....hu;
> Baojun.Xu@....com; judyhsiao@...gle.com; Navada Kanyana, Mukund
> <navada@...com>; cujomalainey@...gle.com; Kutty, Aanya
> <aanya@...com>; Mahmud, Nayeem <nayeem.mahmud@...com>
> Subject: [EXTERNAL] Re: [PATCH v2] ASoc: tas2781: Playback can work when
> only RCA binary loading without dsp firmware loading
> 
> On 5/24/24 20: 47, Shenghao Ding wrote: > In only RCA binary loading case,
> only default dsp program inside the > chip will be work. What does 'RCA'
> stand for? Also clarify the commit title without double negatives, e. g. "Enable
> RCA-based ZjQcmQRYFpfptBannerStart This message was sent from outside
> of Texas Instruments.
> Do not click links or open attachments unless you recognize the source of this
> email and know the content is safe. If you wish to report this message to IT
> Security, please forward the message as an attachment to
> phishing@...t.ti.com
> 
> ZjQcmQRYFpfptBannerEnd
> 
> 
> On 5/24/24 20:47, Shenghao Ding wrote:
> > In only RCA binary loading case, only default dsp program inside the
> > chip will be work.
> 
......................................................................
> > -	if (tas_priv->fw_state == TASDEVICE_DSP_FW_FAIL) {
> > -		/*If DSP FW fail, kcontrol won't be created */
> > -		tasdevice_config_info_remove(tas_priv);
> > +	if (tas_priv->fw_state == TASDEVICE_RCA_FW_OK) {
> > +		/*If DSP FW fail, DSP kcontrol won't be created */
> 
> It looks like you're no longer using PENDING and FAIL states?
> The state machine is becoming really hard to follow.
PENDING and FAIL states have been used in HDA-based tas2563/tas2781 driver

> 
> >  		tasdevice_dsp_remove(tas_priv);
> >  	}
> >  	mutex_unlock(&tas_priv->codec_lock);
> > @@ -466,14 +472,14 @@ static int tasdevice_startup(struct
> > snd_pcm_substream *substream,  {
> >  	struct snd_soc_component *codec = dai->component;
> >  	struct tasdevice_priv *tas_priv =
..................................................................................