linux-kernel - RE: [PATCH v2] net/ncsi: Fix the multi thread manner of NCSI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PSAPR04MB459874779F2FD1C88B7E893AA5F22@PSAPR04MB4598.apcprd04.prod.outlook.com>
Date: Wed, 29 May 2024 07:15:05 +0000
From: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>
To: Paolo Abeni <pabeni@...hat.com>, Delphine_CC_Chiu/WYHQ/Wiwynn
	<Delphine_CC_Chiu@...ynn.com>, "patrick@...cx.xyz" <patrick@...cx.xyz>,
	Samuel Mendoza-Jonas <sam@...dozajonas.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] net/ncsi: Fix the multi thread manner of NCSI driver

Hi,

> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com>
> Sent: Monday, May 27, 2024 5:11 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>;
> patrick@...cx.xyz; Samuel Mendoza-Jonas <sam@...dozajonas.com>; David
> S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>;
> Jakub Kicinski <kuba@...nel.org>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2] net/ncsi: Fix the multi thread manner of NCSI driver
> 
>  [External Sender]
> 
> Hi,
> 
> On Wed, 2024-05-22 at 09:25 +0800, DelphineCCChiu wrote:
> > Currently NCSI driver will send several NCSI commands back to back
> > without waiting the response of previous NCSI command or timeout in
> > some state when NIC have multi channel. This operation against the
> > single thread manner defined by NCSI SPEC(section 6.3.2.3 in
> > DSP0222_1.1.1)
> >
> > According to NCSI SPEC(section 6.2.13.1 in DSP0222_1.1.1), we should
> > probe one channel at a time by sending NCSI commands (Clear initial
> > state, Get version ID, Get capabilities...), than repeat this steps
> > until the max number of channels which we got from NCSI command (Get
> > capabilities) has been probed.
> >
> > Signed-off-by: DelphineCCChiu <delphine_cc_chiu@...ynn.com>
> 
> As noted by Jakub, this looks like a fix. Please include a suitable Fixes tag in the
> tag area and the target tree 'net' inside the subject prefix.
> 
> Thanks!
> 
> Paolo

I have sent a V3 patch which contain Fixes tag and added 'net' in subject prefix.

Thanks!