linux-kernel - Re: [PATCH] iio: dac: ad9739a: drop COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <81ec1d1a-d8de-47e4-a5d4-eeaaf1e806a2@app.fastmail.com>
Date: Wed, 29 May 2024 09:23:11 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: Nuno Sá <noname.nuno@...il.com>,
 "Arnd Bergmann" <arnd@...nel.org>, "Jonathan Cameron" <jic23@...nel.org>
Cc: "Lars-Peter Clausen" <lars@...afoo.de>,
 Nuno Sá <nuno.sa@...log.com>,
 "Dragos Bogdan" <dragos.bogdan@...log.com>,
 "Anshul Dalal" <anshulusr@...il.com>,
 "Andrea Collamati" <andrea.collamati@...il.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option

On Wed, May 29, 2024, at 09:20, Nuno Sá wrote:
> On Tue, 2024-05-28 at 14:12 +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> Build testing without SPI results in a warning:
>> 
>> WARNING: unmet direct dependencies detected for REGMAP_SPI
>>   Depends on [n]: SPI [=n]
>>   Selected by [m]:
>>   - AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
>> 
>> There is no need for this particular COMPILE_TEST option, as allmodconfig
>> and randconfig testing can just assume that SPI is enabled separately.
>> 
>> Drop it to avoid the warning.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>
> Reviewed-by: Nuno Sa <nuno.sa@...log.com>
>
> Only for my understanding. When does COMPILE_TEST makes sense to add?

The most common use is to enable building a driver
that is platform specific on x86 allmodconfig
or on randconfig, e.g.

config LPC18XX_DAC
        tristate "NXP LPC18xx DAC driver"
        depends on ARCH_LPC18XX || COMPILE_TEST
        depends on HAS_IOMEM

Since ARCH_LPC18XX is only visible on arch/arm, the
driver would never be build tested on anything else
without the ||COMPILE_TEST.

      Arnd