linux-kernel - Re: [PATCH] pinctrl: ralink: mt76x8: fix pinmux function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 29 May 2024 09:15:41 +0800
From: 李维豪 <cn.liweihao@...il.com>
To: Sergio Paracuellos <sergio.paracuellos@...il.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, arinc.unal@...nc9.com, sean.wang@...nel.org, 
	matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com, 
	linux-mips@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: ralink: mt76x8: fix pinmux function

Sergio Paracuellos <sergio.paracuellos@...il.com> 于2024年5月28日周二 22:20写道：
>
> On Tue, May 28, 2024 at 3:54 PM Linus Walleij <linus.walleij@...aro.org> wrote:
> >
> > On Mon, May 27, 2024 at 4:21 AM liweihao <cn.liweihao@...il.com> wrote:
> >
> > > From: Weihao Li <cn.liweihao@...il.com>
> > >
> > > The current version of the pinctrl driver has some issues:
> > >
> > > 1. Duplicated "gpio" pmx function
> > >
> > > The common code will add a "gpio" pmx functon to every pin group, so
> > > it's not necessary to define a separate "gpio" pmx function in pin
> > > groups.
> > >
> > > 2. Duplicated pmx function name
> > >
> > > There are some same function name in different pin groups, which will
> > > cause some problems. For example, when we want to use PAD_GPIO0 as
> > > refclk output function, the common clk framework code will search the
> > > entire pin function lists, then return the first one matched, in this
> > > case the matched function list only include the PAD_CO_CLKO pin group
> > > because there are three "refclk" pin function, which is added by
> > > refclk_grp, spi_cs1_grp and gpio_grp.
> > >
> > > To solve this problem, a simple way is just add a pingrp refix to
> > > function name like mt7620 pinctrl driver does.
> > >
> > > 3. Useless "-" or "rsvd" functon
> > >
> > > It's really unnecessary to add a reserved pin mux function to the
> > > function lists, because we never use it.
> > >
> > > Signed-off-by: Weihao Li <cn.liweihao@...il.com>
> >
> > The patch looks good to me and Sergio: patch applied so
> > it gets some testing in linux-next.
> >
> > If Arinc has issues with it or something else occurs I can
> > always drop it again.
>
> Thanks, Linus :)
>
> Best regards,
>     Sergio Paracuellos

Thanks for reviewing the code.

Best regards,
Weihao Li