[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <b779241d-36d8-4728-a126-9340bc569a2d@app.fastmail.com>
Date: Wed, 29 May 2024 09:44:04 +0200
From: "Arnd Bergmann" <arnd@...nel.org>
To: "Jiri Slaby" <jirislaby@...nel.org>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
"Alexey Gladkov" <legion@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, kbd@...ts.linux.dev,
linux-api@...r.kernel.org, linux-fbdev@...r.kernel.org,
linux-serial@...r.kernel.org, "Alexander Viro" <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v5 1/3] VT: Use macros to define ioctls
On Wed, May 29, 2024, at 09:29, Jiri Slaby wrote:
> On 18. 04. 24, 8:18, Greg Kroah-Hartman wrote:
>>
>> This is a nice cleanup, thanks for doing it, I'll just take this one
>> change now if you don't object.
>
> Unfortunately, _IOC_NONE is 1 on some archs as noted by Arnd, and this
> commit changed the kd ioctl values in there which broke stuff as noted
> by Al.
>
> We either:
> * use _IOC(0, X, Y) in here, instead of _IO(X, Y), or
> * define KDIOC(X) as _IOC(0, KD_IOCTL_BASE, X), or
> * revert the commit which landed to -rc1 already.
I would prefer a simple revert, as the other options may
end up more confusing. Another option might be a new
global macro, if we then go an convert all plain ioctl
command numbers to that.
Arnd
Powered by blists - more mailing lists