[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0b737c86-25bd-4bc6-b1c1-1011e15bccfa@baylibre.com>
Date: Wed, 29 May 2024 10:06:34 +0200
From: Alexandre Bailon <abailon@...libre.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, rafael@...nel.org,
daniel.lezcano@...aro.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: rui.zhang@...el.com, lukasz.luba@....com, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/6] dt-bindings: thermal: Add a property to select the
aggregation type
On 5/27/24 08:55, Krzysztof Kozlowski wrote:
> On 24/05/2024 16:31, Alexandre Bailon wrote:
>> This adds a new property named "aggregation" that could be used to
>> select the aggregation type when there are multiple sensors assigned
>> to a thermal zone.
>>
>> Signed-off-by: Alexandre Bailon <abailon@...libre.com>
>> ---
>> .../devicetree/bindings/thermal/thermal-zones.yaml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
>> index fa7a72e2ba44..e6e4b46773e3 100644
>> --- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
>> +++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
>> @@ -111,6 +111,14 @@ patternProperties:
>> coefficients are ordered and are matched with sensors by means of the
>> sensor ID. Additional coefficients are interpreted as constant offset.
>>
>> + aggregation:
>> + $ref: /schemas/types.yaml#/definitions/string
>> + enum:
>> + - avg
>> + - max
>> + description:
>> + Aggregation type to use compute a temperature from multiple sensors.
>
> Hm, why exactly this is a property of hardware? Why on one board you
> would like to average and on other use max? I can only think of a case
> that some sensors give inaccurate data. Otherwise it is OS policyIn the case of Mediatek SoC, we only need max temperature.
I am not really sure if there is really an use case for the average.
Maybe I should drop average if no-one has a use case for it.
Best Regards,
Alexandre
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists