linux-kernel - Re: [PATCH] selftests/openat2: Fix build warnings on ppc64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bk4p3u32.fsf@mail.lhotse>
Date: Wed, 29 May 2024 18:23:13 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 linux-kselftest@...r.kernel.org, skhan@...uxfoundation.org
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] selftests/openat2: Fix build warnings on ppc64

Muhammad Usama Anjum <usama.anjum@...labora.com> writes:
> I was looking at if we can add this flag for ppc64 for all selftests
> somewhere. But there isn't any suitable place other than in KHDR_INCLUDES.
> But there is a series already trying to add _GNU_SOURCE to it.

IMHO adding other flags to KHDR_INCLUDES is not the right solution, it
conflates unrelated things. Some tests may want the kernel headers but
not _GNU_SOURCE, or vice versa.

Adding a separate define for "standard kselftest flags" would be
preferable, and then something like __SANE_USERSPACE_TYPES__ would make
sense being added to it.

> Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

Thanks.

cheers

> On 5/20/24 8:03 PM, Michael Ellerman wrote:
>> Fix warnings like:
>> 
>>   openat2_test.c: In function ‘test_openat2_flags’:
>>   openat2_test.c:303:73: warning: format ‘%llX’ expects argument of type
>>   ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka ‘long
>>   unsigned int’} [-Wformat=]
>> 
>> By switching to unsigned long long for u64 for ppc64 builds.
>> 
>> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
>> ---
>>  tools/testing/selftests/openat2/openat2_test.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/tools/testing/selftests/openat2/openat2_test.c b/tools/testing/selftests/openat2/openat2_test.c
>> index 9024754530b2..5790ab446527 100644
>> --- a/tools/testing/selftests/openat2/openat2_test.c
>> +++ b/tools/testing/selftests/openat2/openat2_test.c
>> @@ -5,6 +5,7 @@
>>   */
>>  
>>  #define _GNU_SOURCE
>> +#define __SANE_USERSPACE_TYPES__ // Use ll64
>>  #include <fcntl.h>
>>  #include <sched.h>
>>  #include <sys/stat.h>
>
> -- 
> BR,
> Muhammad Usama Anjum