[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240529082824.150954-6-21cnbao@gmail.com>
Date: Wed, 29 May 2024 20:28:23 +1200
From: Barry Song <21cnbao@...il.com>
To: akpm@...ux-foundation.org,
linux-mm@...ck.org
Cc: baolin.wang@...ux.alibaba.com,
chrisl@...nel.org,
david@...hat.com,
hanchuanhua@...o.com,
hannes@...xchg.org,
hughd@...gle.com,
kasong@...cent.com,
linux-kernel@...r.kernel.org,
ryan.roberts@....com,
surenb@...gle.com,
v-songbaohua@...o.com,
willy@...radead.org,
xiang@...nel.org,
ying.huang@...el.com,
yosryahmed@...gle.com,
yuzhao@...gle.com,
ziy@...dia.com
Subject: [PATCH v5 5/6] mm: swap: make should_try_to_free_swap() support large-folio
From: Chuanhua Han <hanchuanhua@...o.com>
The function should_try_to_free_swap() operates under the assumption
that swap-in always occurs at the normal page granularity,
i.e., folio_nr_pages() = 1. However, in reality, for large folios,
add_to_swap_cache() will invoke folio_ref_add(folio, nr). To accommodate
large folio swap-in, this patch eliminates this assumption.
Signed-off-by: Chuanhua Han <hanchuanhua@...o.com>
Co-developed-by: Barry Song <v-songbaohua@...o.com>
Signed-off-by: Barry Song <v-songbaohua@...o.com>
Acked-by: Chris Li <chrisl@...nel.org>
Reviewed-by: Ryan Roberts <ryan.roberts@....com>
Reviewed-by: "Huang, Ying" <ying.huang@...el.com>
Reviewed-by: David Hildenbrand <david@...hat.com>
---
mm/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory.c b/mm/memory.c
index c0c6de31a313..10719e5afecb 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3925,7 +3925,7 @@ static inline bool should_try_to_free_swap(struct folio *folio,
* reference only in case it's likely that we'll be the exlusive user.
*/
return (fault_flags & FAULT_FLAG_WRITE) && !folio_test_ksm(folio) &&
- folio_ref_count(folio) == 2;
+ folio_ref_count(folio) == (1 + folio_nr_pages(folio));
}
static vm_fault_t pte_marker_clear(struct vm_fault *vmf)
--
2.34.1
Powered by blists - more mailing lists