linux-kernel - Re: [PATCH MANUALSEL 4.19 1/2] KVM: x86: Handle SRCU initialization failure during page track init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9acccdfe-b7d8-b59d-7b00-d5a266b84d36@huawei.com>
Date: Wed, 29 May 2024 16:29:32 +0800
From: Zenghui Yu <yuzenghui@...wei.com>
To: Sasha Levin <sashal@...nel.org>
CC: Paolo Bonzini <pbonzini@...hat.com>, <linux-kernel@...r.kernel.org>,
	<stable@...r.kernel.org>, Haimin Zhang <tcs_kernel@...cent.com>, TCS Robot
	<tcs_robot@...cent.com>, <tglx@...utronix.de>, <mingo@...hat.com>,
	<bp@...en8.de>, <x86@...nel.org>, <kvm@...r.kernel.org>
Subject: Re: [PATCH MANUALSEL 4.19 1/2] KVM: x86: Handle SRCU initialization
 failure during page track init

On 2021/10/6 19:23, Paolo Bonzini wrote:
> On 06/10/21 13:12, Sasha Levin wrote:
> > From: Haimin Zhang <tcs_kernel@...cent.com>
> >
> > [ Upstream commit eb7511bf9182292ef1df1082d23039e856d1ddfb ]
> >
> > Check the return of init_srcu_struct(), which can fail due to OOM, when
> > initializing the page track mechanism.  Lack of checking leads to a NULL
> > pointer deref found by a modified syzkaller.
> >
> > Reported-by: TCS Robot <tcs_robot@...cent.com>
> > Signed-off-by: Haimin Zhang <tcs_kernel@...cent.com>
> > Message-Id: <1630636626-12262-1-git-send-email-tcs_kernel@...cent.com>
> > [Move the call towards the beginning of kvm_arch_init_vm. - Paolo]
> > Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>
> 
> Acked-by: Paolo Bonzini <pbonzini@...hat.com>

Sasha, will this patch be applied for 4.19?

The same question for the 5.4 backport [*]. It looks like both of them
are missed for unknown reasons.

[*] https://lore.kernel.org/stable/20211006111250.264294-1-sashal@kernel.org