linux-kernel - Re: [PATCH] statx: Update offset commentary for struct statx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240529-ballkontakt-vergibt-b7f8c960eed5@brauner>
Date: Wed, 29 May 2024 10:42:48 +0200
From: Christian Brauner <brauner@...nel.org>
To: John Garry <john.g.garry@...cle.com>
Cc: viro@...iv.linux.org.uk, jack@...e.cz, kent.overstreet@...ux.dev, 
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, adilger@...ger.ca, 
	ebiggers@...nel.org
Subject: Re: [PATCH] statx: Update offset commentary for struct statx

On Wed, May 29, 2024 at 08:17:25AM +0000, John Garry wrote:
> In commit 2a82bb02941f ("statx: stx_subvol"), a new member was added to
> struct statx, but the offset comment was not correct. Update it.
> 
> Signed-off-by: John Garry <john.g.garry@...cle.com>
> 
> diff --git a/include/uapi/linux/stat.h b/include/uapi/linux/stat.h
> index 67626d535316..95770941ee2c 100644
> --- a/include/uapi/linux/stat.h
> +++ b/include/uapi/linux/stat.h
> @@ -126,8 +126,8 @@ struct statx {
>  	__u64	stx_mnt_id;
>  	__u32	stx_dio_mem_align;	/* Memory buffer alignment for direct I/O */
>  	__u32	stx_dio_offset_align;	/* File offset alignment for direct I/O */
> -	__u64	stx_subvol;	/* Subvolume identifier */
>  	/* 0xa0 */
> +	__u64	stx_subvol;	/* Subvolume identifier */
>  	__u64	__spare3[11];	/* Spare space for future expansion */
>  	/* 0x100 */
>  };
> -- 
> 2.31.1
> 

Thanks, applied.
But note that your patch format seems to have tripped b4. I had to apply
it manually.