linux-kernel - Re: [PATCH] mailbox: ARM_MHU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 29 May 2024 11:13:11 +0100
From: Cristian Marussi <cristian.marussi@....com>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Sudeep Holla <sudeep.holla@....com>,
	Jassi Brar <jassisinghbrar@...il.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mailbox: ARM_MHU_V3 should depend on ARM64

On Wed, May 29, 2024 at 09:30:45AM +0200, Geert Uytterhoeven wrote:
> The ARM MHUv3 controller is only present on ARM64 SoCs.  Hence add a
> dependency on ARM64, to prevent asking the user about this driver when
> configuring a kernel for a different architecture than ARM64.
> 

Hi,

the ARM64 dependency was dropped on purpose after a few iterations of
this series since, despite this being an ARM IP, it has really no technical
dependency on ARM arch, not even the usual one on ARM AMBA bus, being this a
platform driver, so it seemed an uneeded artificial restriction to impose...
..having said that, surely my live testing were performed only on arm64 models
as of now.

So, I am not saying that I am against this proposed fix but what is the
issue that is trying to solve, have you seen any compilation error ? or
is it just to avoid the user-prompting ?

Thanks,
Cristian

> Fixes: ca1a8680b134b5e6 ("mailbox: arm_mhuv3: Add driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> The MHUv3 documentation is unclear about whether this can be present
> only on ARM64, or also on ARM.
> Googling 'site:arm.com MHUv3 "aarch32"' shows no results.
> Googling 'site:arm.com MHUv3 "aarch64"' does show results.
> ---
>  drivers/mailbox/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index 3b8842c4a3401579..8d4d1cbb1d4ca625 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -25,6 +25,7 @@ config ARM_MHU_V2
>  
>  config ARM_MHU_V3
>  	tristate "ARM MHUv3 Mailbox"
> +	depends on ARM64 || COMPILE_TEST
>  	depends on HAS_IOMEM || COMPILE_TEST
>  	depends on OF
>  	help
> -- 
> 2.34.1
>