[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240529122232.25360-1-yskelg@gmail.com>
Date: Wed, 29 May 2024 21:22:33 +0900
From: yskelg@...il.com
To: Stefano Stabellini <sstabellini@...nel.org>,
Juergen Gross <jgross@...e.com>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
Cc: skhan@...uxfoundation.org,
sj@...nel.org,
Austin Kim <austindh.kim@...il.com>,
shjy180909@...il.com,
linux-kernel@...r.kernel.org,
xen-devel@...ts.xenproject.org,
linux-kernel-mentees@...ts.linuxfoundation.org,
Yunseong Kim <yskelg@...il.com>
Subject: [PATCH] xen/xenbus: handle potential dangling pointer issue in xen_pcibk_xenbus_probe
From: Yunseong Kim <yskelg@...il.com>
If 'xen_pcibk_init_devices()' fails. This ensures that 'pdev->xdev' does
not point to 'xdev' when 'pdev' is freed.
Signed-off-by: Yunseong Kim <yskelg@...il.com>
---
drivers/xen/xen-pciback/xenbus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index b11e401f1b1e..348d6803b8c0 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -54,6 +54,7 @@ static struct xen_pcibk_device *alloc_pdev(struct xenbus_device *xdev)
INIT_WORK(&pdev->op_work, xen_pcibk_do_op);
if (xen_pcibk_init_devices(pdev)) {
+ pdev->xdev = NULL;
kfree(pdev);
pdev = NULL;
}
--
2.34.1
Powered by blists - more mailing lists