linux-kernel - Re: [PATCH 01/10] dt-bindings: clock: qcom: split the non-PD schema for GCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e32117a4-9616-401f-bf50-23312ce15199@kernel.org>
Date: Wed, 29 May 2024 14:30:36 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Taniya Das <quic_tdas@...cinc.com>,
 Robert Marko <robimarko@...il.com>, Konrad Dybcio
 <konrad.dybcio@...aro.org>, linux-arm-msm@...r.kernel.org,
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] dt-bindings: clock: qcom: split the non-PD schema
 for GCC

On 29/05/2024 09:58, Dmitry Baryshkov wrote:
>>> -    const: 1
>>> -
>>> -  '#reset-cells':
>>> -    const: 1
>>> +allOf:
>>> +  - $ref: qcom,gcc-nopd.yaml
>>>
>>> +properties:
>>>    '#power-domain-cells':
>>>      const: 1
>>
>> So what's left here? One property? Not much benefit. Triple-schema
>> (include something to include something) does not make it readable. Just
>> do not require power-domain-cells in qcom,gcc.yaml.
> 
> And add it to the required list on all relevant platforms? Ack, sounds
> fine to me.

Yes.

Best regards,
Krzysztof