linux-kernel - Re: [PATCH v3] clk: qcom: gcc-ipq9574: Add BRANCH_HALT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <171694812082.574781.5852055342473098003.b4-ty@kernel.org>
Date: Tue, 28 May 2024 21:02:00 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: mturquette@...libre.com,
	sboyd@...nel.org,
	bhupesh.sharma@...aro.org,
	linux-arm-msm@...r.kernel.org,
	linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Md Sadre Alam <quic_mdalam@...cinc.com>
Cc: quic_srichara@...cinc.com,
	quic_varada@...cinc.com,
	stable@...r.kernel.org
Subject: Re: [PATCH v3] clk: qcom: gcc-ipq9574: Add BRANCH_HALT_VOTED flag


On Thu, 09 May 2024 16:24:05 +0530, Md Sadre Alam wrote:
> The crypto_ahb and crypto_axi clks are hardware voteable.
> This means that the halt bit isn't reliable because some
> other voter in the system, e.g. TrustZone, could be keeping
> the clk enabled when the kernel turns it off from clk_disable().
> Make these clks use voting mode by changing the halt check to
> BRANCH_HALT_VOTED and toggle the voting bit in the voting register
> instead of directly controlling the branch by writing to the branch
> register. This fixes stuck clk warnings seen on ipq9574 and saves
> power by actually turning the clk off.
> 
> [...]

Applied, thanks!

[1/1] clk: qcom: gcc-ipq9574: Add BRANCH_HALT_VOTED flag
      commit: 72ceafb587a56e26c905472418c7dc2033c294d3

Best regards,
-- 
Bjorn Andersson <andersson@...nel.org>