linux-kernel - Re: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZlclevRvntUMYG6O@google.com>
Date: Wed, 29 May 2024 05:54:18 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Kai Huang <kai.huang@...el.com>
Cc: "chenhuacai@...nel.org" <chenhuacai@...nel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, 
	"maz@...nel.org" <maz@...nel.org>, "frankja@...ux.ibm.com" <frankja@...ux.ibm.com>, 
	"borntraeger@...ux.ibm.com" <borntraeger@...ux.ibm.com>, "mpe@...erman.id.au" <mpe@...erman.id.au>, 
	"aou@...s.berkeley.edu" <aou@...s.berkeley.edu>, "palmer@...belt.com" <palmer@...belt.com>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "maobibo@...ngson.cn" <maobibo@...ngson.cn>, 
	"pbonzini@...hat.com" <pbonzini@...hat.com>, 
	"loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>, 
	"paul.walmsley@...ive.com" <paul.walmsley@...ive.com>, 
	"kvmarm@...ts.linux.dev" <kvmarm@...ts.linux.dev>, "imbrenda@...ux.ibm.com" <imbrenda@...ux.ibm.com>, 
	"kvm-riscv@...ts.infradead.org" <kvm-riscv@...ts.infradead.org>, 
	"zhaotianrui@...ngson.cn" <zhaotianrui@...ngson.cn>, 
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, 
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, 
	"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>, "anup@...infault.org" <anup@...infault.org>, 
	"oliver.upton@...ux.dev" <oliver.upton@...ux.dev>, 
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load()

On Wed, May 29, 2024, Kai Huang wrote:
> I am not familiar with SVM, but it seems the relevant parts are:
> 
> 	control->pause_filter_count;
> 	vmcb_mark_dirty(svm->vmcb, VMCB_INTERCEPTS);
> 
> And it seems they are directly related to programming the hardware, i.e.,
> they got automatically loaded to hardware during VMRUN.

"control" is the control area of the VMCB, i.e. the above pause_filter_count is
equivalent to a VMCS field.

> They need to be updated in the SVM specific code when @ple_window_dirty is
> true in the relevant code path.
> 
> Anyway, even it is feasible and worth to do, we should do in a separate
> patchset.

Ya.