linux-kernel - Re: [PATCH v2 4/4] remoteproc: qcom_q6v5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <i6fisxbgemwx7prani3zegkcnrll2w5gexcqllk4jqbmiazdz6@tcna7sfs5j63>
Date: Tue, 28 May 2024 19:10:34 -0700
From: Bjorn Andersson <andersson@...nel.org>
To: Chris Lew <quic_clew@...cinc.com>
Cc: Baolin Wang <baolin.wang@...ux.alibaba.com>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>, 
	Waiman Long <longman@...hat.com>, Boqun Feng <boqun.feng@...il.com>, 
	Jonathan Corbet <corbet@....net>, Mathieu Poirier <mathieu.poirier@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
	Konrad Dybcio <konrad.dybcio@...aro.org>, linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-doc@...r.kernel.org, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	Richard Maina <quic_rmaina@...cinc.com>
Subject: Re: [PATCH v2 4/4] remoteproc: qcom_q6v5_pas: Add hwspinlock bust on
 stop

On Fri, May 24, 2024 at 06:26:43PM -0700, Chris Lew wrote:
> From: Richard Maina <quic_rmaina@...cinc.com>
> 
> When remoteproc goes down unexpectedly this results in a state where any
> acquired hwspinlocks will remain locked possibly resulting in deadlock.
> In order to ensure all locks are freed we include a call to
> qcom_smem_bust_hwspin_lock_by_host() during remoteproc shutdown.
> 
> For qcom_q6v5_pas remoteprocs, each remoteproc has an assigned smem
> host_id. Remoteproc can pass this id to smem to try and bust the lock on
> remoteproc stop.
> 
> This edge case only occurs with q6v5_pas watchdog crashes. The error
> fatal case has handling to clear the hwspinlock before the error fatal
> interrupt is triggered.
> 
> Signed-off-by: Richard Maina <quic_rmaina@...cinc.com>
> Signed-off-by: Chris Lew <quic_clew@...cinc.com>

Reviewed-by: Bjorn Andersson <andersson@...nel.org>

Regards,
Bjorn