linux-kernel - [PATCH 2/2] drivers: thermal: fix zero weighted request power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Wed, 29 May 2024 21:52:47 +0800
From: Chia-Hao Liu <a0921444212@...il.com>
To: lukasz.luba@....com
Cc: rafael@...nel.org,
	daniel.lezcano@...aro.org,
	rui.zhang@...el.com,
	linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Chia-Hao Liu <a0921444212@...il.com>
Subject: [PATCH 2/2] drivers: thermal: fix zero weighted request power

When the product of weight and req_power is less than 1024,
the `frac_to_int()` macro causes the weighted_req_power to
become zero, it will cause granted_power to be zero.
To address issue, I add a check:
If the weight is less than 1024, frac_to_int() is not applied
to avoid setting the weighted_req_power to zero.

Signed-off-by: Chia-Hao Liu <a0921444212@...il.com>
---
 drivers/thermal/gov_power_allocator.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
index 336b48745..c878cbb62 100644
--- a/drivers/thermal/gov_power_allocator.c
+++ b/drivers/thermal/gov_power_allocator.c
@@ -434,10 +434,10 @@ static void allocate_power(struct thermal_zone_device *tz, int control_temp)
 		else
 			weight = instance->weight;
         
-        if (weight < 1024) 
-		    pa->weighted_req_power = weight * pa->req_power;
+		if (weight < 1024)
+			pa->weighted_req_power = weight * pa->req_power;
 		else
-            pa->weighted_req_power = frac_to_int(weight * pa->req_power);
+			pa->weighted_req_power = frac_to_int(weight * pa->req_power);
 
 		ret = cdev->ops->state2power(cdev, instance->lower,
 					     &pa->max_power);
-- 
2.34.1