linux-kernel - Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 29 May 2024 15:00:34 +0100
From: Marc Zyngier <maz@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: Anup Patel <apatel@...tanamicro.com>,
	devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-riscv@...ts.infradead.org,
	Saravana Kannan <saravanak@...gle.com>
Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map

On Wed, 29 May 2024 14:44:07 +0100,
Rob Herring <robh@...nel.org> wrote:
> 
> On Wed, May 29, 2024 at 1:33 AM Marc Zyngier <maz@...nel.org> wrote:
> >
> > On Wed, 29 May 2024 06:15:52 +0100,
> > Anup Patel <apatel@...tanamicro.com> wrote:
> > >
> > > This breaks for RISC-V because we don't have "#address-cells"
> > > property in interrupt controller DT node and of_bus_n_addr_cells()
> > > retrieves "#address-cells" from the parent of interrupt controller.
> >
> > That's a feature, not a bug. #address-cells, AFAICT, applies to all
> > child nodes until you set it otherwise.
> 
> That may be supported in some places, but only because of buggy DTs
> (we're talking 2000 era). Current dtc should warn if an interrupt
> controller node doesn't have #address-cells AND is referred to by
> interrupt-map.

Clearly that didn't deter the riscv folks from doing silly things, and
we're now stuck with more random hacks.

Anyhow, I vented enough about this, and I'm going back to doing
semi-useful stuff.

	M.

-- 
Without deviation from the norm, progress is not possible.