linux-kernel - Re: [PATCH v2 2/3] drm/bridge: tc358767: Only print GPIO debug output if they actually occur

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN6tsi6k3Fv5oQaWbDakaq6_=f-gmVY21OsQ5vxAdepUvU5VBQ@mail.gmail.com>
Date: Wed, 29 May 2024 16:02:41 +0200
From: Robert Foss <rfoss@...nel.org>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] drm/bridge: tc358767: Only print GPIO debug output
 if they actually occur

On Thu, May 16, 2024 at 8:25 AM Alexander Stein
<alexander.stein@...tq-group.com> wrote:
>
> Currently the output the following output is printed upon each interrupt:
>  tc358767 1-000f: GPIO0:
> This spams the kernel log while debugging an IRQ storm from the bridge.
> Only print the debug output if the GPIO hotplug event actually happened.
>
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
>  drivers/gpu/drm/bridge/tc358767.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index de62a7e2eafec..8874713bdd4a4 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -2146,11 +2146,11 @@ static irqreturn_t tc_irq_handler(int irq, void *arg)
>                 bool h = val & INT_GPIO_H(tc->hpd_pin);
>                 bool lc = val & INT_GPIO_LC(tc->hpd_pin);
>
> -               dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin,
> -                       h ? "H" : "", lc ? "LC" : "");
> -
> -               if (h || lc)
> +               if (h || lc) {
> +                       dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin,
> +                               h ? "H" : "", lc ? "LC" : "");
>                         drm_kms_helper_hotplug_event(tc->bridge.dev);
> +               }
>         }
>
>         regmap_write(tc->regmap, INTSTS_G, val);
> --
> 2.34.1
>
>

Reviewed-by: Robert Foss <rfoss@...nel.org>