linux-kernel - Re: [PATCH v7 2/4] spi: cadence: Add Marvell xSPI IP overlay changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 31 May 2024 03:38:39 +0800
From: kernel test robot <lkp@...el.com>
To: Witold Sadowski <wsadowski@...vell.com>, linux-kernel@...r.kernel.org,
	linux-spi@...r.kernel.org, devicetree@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, broonie@...nel.org,
	robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, pthombar@...ence.com,
	Witold Sadowski <wsadowski@...vell.com>
Subject: Re: [PATCH v7 2/4] spi: cadence: Add Marvell xSPI IP overlay changes

Hi Witold,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-spi/for-next]
[also build test ERROR on linus/master v6.10-rc1 next-20240529]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Witold-Sadowski/spi-dt-bindings-cadence-Add-Marvell-overlay-bindings-documentation-for-Cadence-XSPI/20240530-060250
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20240529220026.1644986-3-wsadowski%40marvell.com
patch subject: [PATCH v7 2/4] spi: cadence: Add Marvell xSPI IP overlay changes
config: arm-randconfig-004-20240531 (https://download.01.org/0day-ci/archive/20240531/202405310322.RIyE2GGE-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240531/202405310322.RIyE2GGE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405310322.RIyE2GGE-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/spi/spi-cadence-xspi.c:496:15: error: call to undeclared function 'readq'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
                           *buf64++ = readq(addr);
                                      ^
   drivers/spi/spi-cadence-xspi.c:499:10: error: call to undeclared function 'readq'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
                           tmp = readq(addr);
                                 ^
   drivers/spi/spi-cadence-xspi.c:505:9: error: call to undeclared function 'readq'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
                   tmp = readq(addr);
                         ^
>> drivers/spi/spi-cadence-xspi.c:520:4: error: call to undeclared function 'writeq'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
                           writeq(*buf64++, addr);
                           ^
   drivers/spi/spi-cadence-xspi.c:524:4: error: call to undeclared function 'writeq'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
                           writeq(tmp, addr);
                           ^
   drivers/spi/spi-cadence-xspi.c:530:3: error: call to undeclared function 'writeq'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
                   writeq(tmp, addr);
                   ^
   6 errors generated.


vim +/readq +496 drivers/spi/spi-cadence-xspi.c

   485	
   486	static void mrvl_ioreadq(void __iomem  *addr, void *buf, int len)
   487	{
   488		int i = 0;
   489		int rcount = len / 8;
   490		int rcount_nf = len % 8;
   491		uint64_t tmp;
   492		uint64_t *buf64 = (uint64_t *)buf;
   493	
   494		if (((uint64_t)buf % 8) == 0) {
   495			for (i = 0; i < rcount; i++)
 > 496				*buf64++ = readq(addr);
   497		} else {
   498			for (i = 0; i < rcount; i++) {
   499				tmp = readq(addr);
   500				memcpy(buf+(i*8), &tmp, 8);
   501			}
   502		}
   503	
   504		if (rcount_nf != 0) {
   505			tmp = readq(addr);
   506			memcpy(buf+(i*8), &tmp, rcount_nf);
   507		}
   508	}
   509	
   510	static void mrvl_iowriteq(void __iomem *addr, const void *buf, int len)
   511	{
   512		int i = 0;
   513		int rcount = len / 8;
   514		int rcount_nf = len % 8;
   515		uint64_t tmp;
   516		uint64_t *buf64 = (uint64_t *)buf;
   517	
   518		if (((uint64_t)buf % 8) == 0) {
   519			for (i = 0; i < rcount; i++)
 > 520				writeq(*buf64++, addr);
   521		} else {
   522			for (i = 0; i < rcount; i++) {
   523				memcpy(&tmp, buf+(i*8), 8);
   524				writeq(tmp, addr);
   525			}
   526		}
   527	
   528		if (rcount_nf != 0) {
   529			memcpy(&tmp, buf+(i*8), rcount_nf);
   530			writeq(tmp, addr);
   531		}
   532	}
   533	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki