linux-kernel - Re: [PATCH v2 0/6] selftests/x86: fix build errors and warnings found via clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 30 May 2024 13:00:55 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Dave Hansen <dave.hansen@...el.com>, Shuah Khan <shuah@...nel.org>
Cc: angquan yu <angquan21@...il.com>,
 "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
 Ingo Molnar <mingo@...nel.org>, Binbin Wu <binbin.wu@...ux.intel.com>,
 Alexey Dobriyan <adobriyan@...il.com>,
 Rick Edgecombe <rick.p.edgecombe@...el.com>,
 Sohil Mehta <sohil.mehta@...el.com>, Yu-cheng Yu <yu-cheng.yu@...el.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Valentin Obst <kernel@...entinobst.de>, linux-kselftest@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev, x86@...nel.org,
 Muhammad Usama Anjum <usama.anjum@...labora.com>
Subject: Re: [PATCH v2 0/6] selftests/x86: fix build errors and warnings found
 via clang

On 5/30/24 12:46 PM, Dave Hansen wrote:
> On 5/27/24 14:00, John Hubbard wrote:
>> John Hubbard (6):
>>    selftests/x86: build test_FISTTP.c with clang
>>    selftests/x86: build fsgsbase_restore.c with clang
>>    selftests/x86: build sysret_rip.c with clang
>>    selftests/x86: avoid -no-pie warnings from clang during compilation
>>    selftests/x86: remove (or use) unused variables and functions
>>    selftests/x86: fix printk warnings reported by clang
> 
> John, could you and Muhammad have a chat and perhaps settle on a series
> series that gets acks from both of you?
> 
>> https://lore.kernel.org/all/20240501122918.3831734-1-usama.anjum@collabora.com/
> 
> I had Muhammad's in my queue and didn't realize we had two overlapping
> series' bouncing around until now.

Aha OK. Muhummad, after looking through this, I see that our
test_FISTTP.c fix is identical, and that's about it. My series goes
a bit deeper IMHO and completely fixes all the errors; the tradeoff
is that it is more intrusive. Which I think is appropriate.

Would you be OK with my posting v3 that uses your patch for
test_FISTTP.c [1], and the rest of my patches for the rest?

[1] 
https://lore.kernel.org/all/20240501122918.3831734-7-usama.anjum@collabora.com/

thanks,
-- 
John Hubbard
NVIDIA