linux-kernel - Re: [PATCHv6 bpf-next 1/9] x86/shstk: Make return uprobe work with shadow stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b70a995dda46c020c9e7c78f0e68560f0b61441.camel@intel.com>
Date: Thu, 30 May 2024 23:04:37 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "jolsa@...nel.org" <jolsa@...nel.org>, "mhiramat@...nel.org"
	<mhiramat@...nel.org>, "rostedt@...dmis.org" <rostedt@...dmis.org>,
	"ast@...nel.org" <ast@...nel.org>, "andrii@...nel.org" <andrii@...nel.org>,
	"oleg@...hat.com" <oleg@...hat.com>, "daniel@...earbox.net"
	<daniel@...earbox.net>
CC: "debug@...osinc.com" <debug@...osinc.com>, "luto@...nel.org"
	<luto@...nel.org>, "bp@...en8.de" <bp@...en8.de>, "yhs@...com" <yhs@...com>,
	"songliubraving@...com" <songliubraving@...com>, "linux-api@...r.kernel.org"
	<linux-api@...r.kernel.org>, "x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"john.fastabend@...il.com" <john.fastabend@...il.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>,
	"linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>, "linux-man@...r.kernel.org"
	<linux-man@...r.kernel.org>, "peterz@...radead.org" <peterz@...radead.org>
Subject: Re: [PATCHv6 bpf-next 1/9] x86/shstk: Make return uprobe work with
 shadow stack

On Tue, 2024-05-21 at 12:48 +0200, Jiri Olsa wrote:
> Currently the application with enabled shadow stack will crash
> if it sets up return uprobe. The reason is the uretprobe kernel
> code changes the user space task's stack, but does not update
> shadow stack accordingly.
> 
> Adding new functions to update values on shadow stack and using
> them in uprobe code to keep shadow stack in sync with uretprobe
> changes to user stack.
> 
> Fixes: 8b1c23543436 ("x86/shstk: Add return uprobe support")
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
Acked-by: Rick Edgecombe <rick.p.edgecombe@...el.com>