linux-kernel - Re: [PATCH 1/2] selftests/openat2: fix clang build failures: -static-libasan, LOCAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00ba2d8c-6b0f-46f4-bd19-bce19842c356@nvidia.com>
Date: Wed, 29 May 2024 21:35:20 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
CC: Andrew Morton <akpm@...ux-foundation.org>, Ilpo Järvinen
	<ilpo.jarvinen@...ux.intel.com>, Maciej Wieczor-Retman
	<maciej.wieczor-retman@...el.com>, Christian Brauner <brauner@...nel.org>,
	Alexey Gladkov <legion@...nel.org>, Valentin Obst <kernel@...entinobst.de>,
	<linux-kselftest@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
	<llvm@...ts.linux.dev>, Ryan Roberts <ryan.roberts@....com>, Shuah Khan
	<shuah@...nel.org>
Subject: Re: [PATCH 1/2] selftests/openat2: fix clang build failures:
 -static-libasan, LOCAL_HDRS

On 5/29/24 8:58 PM, Muhammad Usama Anjum wrote:
> On 5/10/24 10:56 PM, John Hubbard wrote:
>> On 5/10/24 4:52 AM, Ryan Roberts wrote:
>>> On 04/05/2024 05:43, John Hubbard wrote:
>> ...
>> In Make, the arguments to functions include *all* spaces, so it's good
>> practice to not add spaces in most function calls, unless they are
>> definitely desired.
>>
>> Also, you only ever want one of those $(CC) options, so saying so is a
>> nice touch. Neither of these is a functional issue in [2], but you could
>> do this on top of the patch (I'm only showing the openat2 case):
> I was building with CC=clang and build was still failing. We should be able
> to build by CC=clang and LLVM=1 both. It seems like patches still haven't
> been accepted. Let's get a v2 out to fix this.
> 

Yes, these are about next on the list, and I expect to post a v2 or its moral
equivalent tomorrow or the next day at the latest.

For the CC=clang vs. LLVM=1 issue in particular, I've already posted a
fix, please see my "[PATCH 0/2] selftests/lib.mk: LLVM=1, CC=clang, and
warnings" [1] that went out just yesterday.

[1] https://lore.kernel.org/20240529020842.127275-1-jhubbard@nvidia.com

thanks,
-- 
John Hubbard
NVIDIA